Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neyberson/browser class #4

Merged
merged 32 commits into from
Aug 12, 2024
Merged

Neyberson/browser class #4

merged 32 commits into from
Aug 12, 2024

Conversation

neyberson
Copy link
Collaborator

No description provided.

ayjayt
ayjayt requested changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@ayjayt ayjayt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. browser.py no Browser.py
  2. disponible en __init__
  3. pruebalo, cambia app.py para usar esta clase nueva, trata de identificar la apertura y cierre en el administrador de tareas

devtools/Browser.py Outdated Show resolved Hide resolved
devtools/Browser.py Outdated Show resolved Hide resolved
devtools/Browser.py Outdated Show resolved Hide resolved
devtools/Browser.py Outdated Show resolved Hide resolved
@neyberson
Move Pipe and PipeClosedError classes to pipe.py
ae0108e
@neyberson
Move chrome_wrapper.py to devtools/
862cfbd
@neyberson
Change attribute default values at Browser class
5760702
@neyberson
Update attribute uses at Browser class
1d9d0ee
@neyberson
Update imports at Browser.py
88fd14a
@neyberson
Delete start_browser() and improve init at Browser class
3104e8d
@neyberson
Format code at Browser.py
b178434
@neyberson
Change Browser.py to browser.py
dd51eb9
@neyberson
Add debug attribute and conditionals at init from Browser
2604361
@neyberson
Add Browser to __init__.py
4fc71e5
@neyberson
Delete some files at app/
8589146
@neyberson
Add conditionals to use wait() or pause() at chrome_wrapper.py
e988209
@neyberson
Format code at chrome_wrapper.py
d29c307
@neyberson
Rename pipes to pipe at Browser
7cf859d
@neyberson
Update app.py with new devtools.Browser
65a489d
@neyberson
Delete some imports at app.py
fb98762
@neyberson
Add time.sleep(10) at app.py
1ac02bd
@neyberson
Create __enter__() at Browser
8c199a9
@neyberson
Create __exit__() at Browser
8f4b926
@neyberson
Delete proc parameter at close_browser() from Browser
4ec6105
@neyberson
Format code at browser.py
a84749d
@neyberson
Delete proc variable at app.py
002b604
@ayjayt
Copy link
Collaborator

ayjayt commented Aug 12, 2024

Si probamos with voy a aprobar

@neyberson neyberson merged commit 19c004a into main Aug 12, 2024
1 check passed
@neyberson neyberson deleted the neyberson/browser_class branch August 15, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayjayt ayjayt ayjayt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neyberson @ayjayt