Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Andrew/windows modifications #2

Merged
merged 36 commits into from
Aug 8, 2024
Merged

Andrew/windows modifications #2

merged 36 commits into from
Aug 8, 2024

Conversation

ayjayt
Copy link
Collaborator

@ayjayt ayjayt commented Aug 7, 2024

This pull request

a) tests ruff
b) adds support for windows in gitbash in app
c) is not finished, does not support powershell

ayjayt and others added 30 commits August 6, 2024 16:20
@ayjayt
Kill child if terminate times out 5sec
a4a0dec
@ayjayt
Remove old json decoder
a5fef91
@ayjayt
Add support for windows
8bf073a
@ayjayt
Update reference
a827613
@ayjayt
Fix typo from search/replace
a05eb29
@ayjayt
Add read_jsons to Pipe() class
b4472da
@ayjayt
Use new read_jsons api
5154e63
@ayjayt
Fix typo from search/replace
4823083
@ayjayt
Merge branch 'main' into andrew/windows-modifications
2c7177e
@ayjayt
Fixup printing outputs and add tests to app
5260a91
@ayjayt
Add some command simulations to test
dcb2345
@ayjayt
Improve comments
edaa008
@ayjayt
Merge branch 'main' into andrew/windows-modifications
449ca8c
@ayjayt
Remove py from reference to avoid linting
e042fad
@ayjayt
Add debug to read_jsons
09c4ed8
@ayjayt
Silence ruff linter
aec58df
@ayjayt
Add editor files to gitignore
66b572c
@ayjayt
Add some solutions for windows signaling
f7cdafa
@ayjayt
Increase sleep time
128d671
@ayjayt
Finish up windows signaling
ee0d78c
@neyberson
Delete some imports at app_devtools.py
afc220b
@neyberson
Delete useless keys and values at some variables from app_devtools.py
21acb72
@neyberson
Change some string values at app_devtools.py
0c88c3b
@neyberson
Delete some prints and mix list_r_session_id values into list_r from …
57c589b 
…app_devtools.py
@neyberson
Add Connection object and change print at app_devtools.py
cc7b96e
@neyberson
Improve print loop using conditionals at app_devtools.py
0428e15
@neyberson
Add some comments at app_devtools.py
53001ed
@neyberson
Format code at app_devtools.py
1746f92
@neyberson
Lint code at app_devtools.py
baccf7f
@neyberson
Add default value to params attribute at Session class
41bde75
@ayjayt
Copy link
Collaborator Author

ayjayt commented Aug 8, 2024

si quieres, puedes aceptar

@ayjayt
Copy link
Collaborator Author

ayjayt commented Aug 8, 2024

@neyberson

@neyberson neyberson merged commit b6213d6 into main Aug 8, 2024
1 check passed
@neyberson neyberson deleted the andrew/windows-modifications branch August 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayjayt @neyberson