Switch json to simplejson #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support date/datetime object in NumpyEncoder.
Python's standard json encoder doesn't support NaN values (nan, +- inf) json doesn't, simplejson does to an extent. (all get converted to null)
|
I'd like to incorporate #166 into this issue edit: done |
|
|
There seems to be support for adding the orjson dependency which will have broader encoding support. This PR introduces our first external dependency, but I think it'll be very valuable. Will do it today. |
|
@neyberson can you please look at changing |
gvwilson
approved these changes
Nov 20, 2024
|
want me to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's standard json encoder doesn't support NaN values (nan, +- inf) json doesn't,
simplejsondoes to an extent. (all get converted to null)This will bring us back to our previous basic support for json, but I'd this route will likely help me fix some fill errors I was seeing in plotly earlier. Converted all NaN to null doesn't work and breaks fills when using jupyter- but it would be a change for pypi as well.
closes plotly/Kaleido#228