Neyberson/connection #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a temporary directory as --user-data-dir to chrome flags will trick chrome into thinking a new user is running chrome, and therefore wont interfere with the currently running session.
Andrew/user data dir
Andrew/revision connection
Andrew/connection restructure
…otocol into neyberson/connection
ayjayt
approved these changes
Sep 2, 2024
ayjayt
requested changes
Sep 3, 2024
| def add_tab(self, tab): | ||
| if not isinstance(tab, Tab): | ||
| raise TypeError("tab must be an object of class Tab") | ||
| self.sessions[tab.target_id] = tab |
There was a problem hiding this comment.
el error mio pero debes cuidarlos tambien, no debe estar en self.sessions[] debe esta en self.tabs[]
| def remove_session(self, target_id): | ||
| if isinstance(target_id, Tab): | ||
| target_id = target_id.target_id | ||
| del self.sessions[target_id] |
| print(f"The following session was deleted: {session_obj.session_id}") | ||
| class Tab(Target): | ||
| def __init__(self, target_id, browser): | ||
| super().__init__(self, target_id, browser.protocol) |
There was a problem hiding this comment.
tambien mal, no debe ser init(self
| return True | ||
|
|
||
| def run_output_thread(self, debug=False): | ||
| print("Start run_output_thread() to improve debugging".center(6, "-")) |
There was a problem hiding this comment.
si vas a imprimir debug, debe estar a file=sys.stderr o lo que sea, y solo con debug=True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.