Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for plone.org issues 73 and 110 #161

Merged

Conversation

miropaananen
Copy link

@miropaananen miropaananen commented Jan 19, 2024

Fixes #73
Fixes #110

@miropaananen miropaananen changed the title Fix for plone.org issues 73, 87 and 110 Fix for plone.org issues 73 and 110 Jan 19, 2024
@miropaananen
Copy link
Author

I deleted issue 87. I taught I had fixed it but I tested my changes again and the issue still persisted. Sorry for the inconvenience. I think had investigated it but ran out of time during the sprint.

@Fosten
Copy link
Contributor

Fosten commented Jan 19, 2024

Removing h2 {text-align: center;} in site.overrides should also fix Issue #109 but may cause unwanted formatting issues in other places. I agree it should be removed, but content will need to be reviewed afterwards to see if we need re-add h2 {text-align: center;} in places where it is desired.

Copy link
Member

@fredvd fredvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Miro

@fredvd fredvd merged commit 91de044 into plone:main Jan 24, 2024
@stevepiercy
Copy link
Contributor

See also #155. I'm not sure whether this pull request fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants