Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 new API calls: /v0.1/Bridge & /v0.1/Command, the first works… #70

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

digination
Copy link

well eg after a BulkCall to establish a bridge between 2 legs given their respective CallUUID, the second extends the API to issue arbitrary freeswitch commands directly through the RESTAPI.

WintermeW added 3 commits January 19, 2012 23:09
…well eg after a BulkCall to establish a bridge between 2 legs given their respective CallUUID, the second extends the API to issue arbitrari freeswitch commands directly through the RESTAPI
…either api() or bgapi(), now returns command result as message or Job-uuid if bgapi. Added 2 new API calls: create_uuid , to make Freeswitch return a real uuid, and get_var UUID to be able to retrieve channel variables
@mike-plivo
Copy link
Member

Hi,

  • for Bridge :
    did you try placing two calls in a restxml scenario (like an infinite play loop) and tried bridge (uuid_bridge) both calls ?
    Last time I have tried didn't work for me, seems oubound socket application hangup both calls .
  • for Command, I think we must not allow it except if a config option was set (as its dangerous and everybody can inject any api commands he wants)
    Maybe we can add a config option in plivo:
    FS_ALLOW_CUSTOM_COMMANDS = true/false , which is set by default to false .
  • some indents are wrong in the pull request, maybe some mix of tab and spaces ?

@ghost ghost assigned mike-plivo Jan 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants