pkp/pkp-lib#10571 limit email template access by user groups #10581
+680
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
5 times, most recently
from
0352bec
to
ba47e2b
Compare
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
7 times, most recently
from
3cb222d
to
cf0580b
Compare
taslangraham
changed the title
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
2 times, most recently
from
8b6f076
to
75b9ed1
Compare
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
from
75b9ed1
to
405e376
Compare
ewhanson
requested changes
Nov 21, 2024
controllers/grid/users/reviewer/form/AdvancedSearchReviewerForm.php
Outdated
Show resolved
Hide resolved
| * | ||
| */ | ||
| public function installEmailTemplates( | ||
| string $templatesFile, | ||
| array $locales = [], | ||
| ?string $emailKey = null, | ||
| bool $skipExisting = false | ||
| bool $skipExisting = false, | ||
| $recordTemplateGroupAccess = false |
There was a problem hiding this comment.
I mention this directly below, but I don't think this optional parameter will be necessary. I think the assumption of "unrestricted if no additional data provided" below is enough.
There was a problem hiding this comment.
For posterity, we talked about it and decided to keep thing $recordTemplateGroupAccess parameter as described here to avoid any issues as part of the upgrade process.
classes/migration/upgrade/V3_6_0/I10403_EmailTemplateUserGroupAccess.php
Show resolved
Hide resolved
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
from
efecaab
to
a5f43dc
Compare
…il templates within a mailable
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
from
a5f43dc
to
d2e9586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10571