WIP lore/worldbuilding/station lobby #5283
Conversation
| @@ -1893,7 +1893,7 @@ | |||
| }, | |||
| "STATION_DOCKS": { | |||
| "description": "Information shown in the station lobby, for total number of docking pads", | |||
| "message": "Our total capacity is {total_docking_pads} docking pads." | |||
| "message": "Your ship is docked on pad {shipbay} out of {bays} docking pads." | |||
There was a problem hiding this comment.
Nice idea! Is the "out of bays" part necessary?
There was a problem hiding this comment.
I dont know but see the diff, how many bays there are in the station was all there was before, I only added the shipbay
There was a problem hiding this comment.
Yeah, then I realized that you replace the line, not adding another about the pads. Sorry
Update en.json Update en.json
| end | ||
|
|
||
| local station_docks = string.interp(l.STATION_DOCKS, { total_docking_pads = string.format("%d", station.numDocks),}) | ||
| local substrings = { shipbay = station:GetAssignedBayNumber(Game.player), |
There was a problem hiding this comment.
The bays go from 1 up so I think this should probably be:
shipbay = station:GetAssignedBayNumber(Game.player) + 1
data/lang/lore/en.json
Outdated
| "description" : "", | ||
| "message" : "Moscow Spaceflight museum is a must see! See how it all started, including an actual moon lander recovered from the moon!" | ||
| }, | ||
| "SOL_EARTH_OLYMPUS" : { |
There was a problem hiding this comment.
sol_mars_cydonia you mean?
There was a problem hiding this comment.
No, Cydonia is another station. The text (ski slope...) shows correct on Olympus Mons station but the token name looked a bit off, that's all.
There was a problem hiding this comment.
I just abbreviated it because its unique enough with the sol_mars
There was a problem hiding this comment.
its unique enough with the sol_mars
Yes, it would have been, but you named it SOL_EARTH_OLYMPUS. I don't know if we're talking about the same thing here and I may have misunderstood everything.
There was a problem hiding this comment.
oopsies. carbon copy much? yes. I though you were talking about cydonia because of the alien emoji
There was a problem hiding this comment.
Ah, the Little Green Men team! You need to also fix the string in SCC0000000013-OlympusMons.json. ;)
There was a problem hiding this comment.
thanks,, seems im not a my best today.
| @@ -42,7 +42,7 @@ local max_flavours = 22 | |||
| local startLocations = { | |||
| {['name']=lui.START_AT_MARS, | |||
| ['desc']=lui.START_AT_MARS_DESC, | |||
| ['location']=SystemPath.New(0,0,0,0,18), | |||
| ['location']=SystemPath.New(0,0,0,0,22), | |||
There was a problem hiding this comment.
There's an instance of '0,0,0,0,18' in /src/main.cpp also. For starting from the command line.
|
Just FYI @joonicks I'd recommend marking this PR as a draft until you're ready to pull it out of WIP and get a full review on its features - it makes it a little easier for us to manage which PRs are still in progress and which are awaiting review and merge. |
|
@Web-eWorks If only I knew how to |
Update SCC0000000013-OlympusMons.json
incremental changes
impaktor
force-pushed
the
master
branch
3 times, most recently
from
876b6fc
to
b5bc47c
Compare
impaktor
force-pushed
the
master
branch
2 times, most recently
from
90e4530
to
6a3a044
Compare
brings customization to space stations
json files tied to individual stations to provide attributes to base further customizations on
techLevel can be overridden per station