Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix out of bounds access panic #356

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix out of bounds access panic #356

merged 1 commit into from
Sep 18, 2023

Conversation

boks1971
Copy link
Contributor

Drop packet exceeding size of input buffer.

@boks1971
Fix out of bounds access panic
cfe861d 
Drop packet exceeding size of input buffer.
@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
server.go 0.00%

📢 Thoughts on this report? Let us know!.

@boks1971
Copy link
Contributor Author

boks1971 commented Sep 18, 2023 •
edited
Loading

@reviewers: I put in a continue to drop the bad packet. Instead, should we send in the truncated packet to the handler? (after setting proper bounds).

We hit this panic in a LiveKit installation.

@boks1971 boks1971 merged commit f15249d into master Sep 18, 2023
15 of 16 checks passed
@boks1971 boks1971 deleted the raja_panic branch September 18, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnderrauber cnderrauber cnderrauber approved these changes

@stv0g stv0g Awaiting requested review from stv0g

@davidzhao davidzhao Awaiting requested review from davidzhao

@Sean-Der Sean-Der Awaiting requested review from Sean-Der

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boks1971 @cnderrauber