fix: Some bad math with the JitterBuffer sequence tracking #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 72.39% 72.45% +0.05%
==========================================
Files 79 79
Lines 3648 3648
==========================================
+ Hits 2641 2643 +2
+ Misses 870 869 -1
+ Partials 137 136 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thatsnotright
force-pushed
the
rob/fix-253
branch
2 times, most recently
from
1a036cf
to
31069e2
Compare
|
@Sean-Der Can you let me know if this PR is good to go? Thanks! |
Sean-Der
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm not sure what I was thinking, uint16 should wrap itself correctly.
Reference issue
Fixes #253