JitterBuffer: Interceptor #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 72.08% 72.14% +0.06%
==========================================
Files 77 79 +2
Lines 3582 3644 +62
==========================================
+ Hits 2582 2629 +47
- Misses 866 876 +10
- Partials 134 139 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thatsnotright
force-pushed
the
rob/jitterbuffer_interceptor
branch
2 times, most recently
from
2668bc2
to
249b5d0
Compare
The JitterBufferInterceptor is designed to fit in a RemoteStream pipeline and buffer incoming packets for a short period (currently defaulting to 50 packets) before emitting packets to be consumed by the next step in the pipeline. The caller must ensure they are prepared to handle an ErrPopWhileBuffering in the case that insufficient packets have been received by the jitter buffer. The caller should retry the operation at some point later as the buffer may have been filled in the interim. The caller should also be aware that an ErrBufferUnderrun may be returned in the case that the initial buffering was sufficient and playback began but the caller is consuming packets (or they are not arriving) quickly enough.
thatsnotright
force-pushed
the
rob/jitterbuffer_interceptor
branch
from
249b5d0
to
6d74945
Compare
|
@Sean-Der I'm not sure why the nack test failed for WASM this run but not others. I think this PR is close to ready but I'd like to see what else you think it needs? |
|
@thatsnotright Could you look at my issue please? |
Sean-Der
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements a RemoteStream jitter buffer interceptor.