Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlreplay: do not write traffic files if meta exists #721

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #716

Problem Summary:
Writing meta may overwrite a system file with the same name, which can be used by attackers, so a precheck is needed before capturing.

What is changed and how it works:
Precheck the file meta before traffic capture. If the file exists, quit.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Do not start traffic capture if the file meta exists

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox November 21, 2024 10:58
Copy link

ti-chi-bot bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from djshow832, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S label Nov 21, 2024
Copy link

ti-chi-bot bot commented Nov 21, 2024

@djshow832: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test 55d6eb2 link true /test unit-test
pull-mysql-connector-test 55d6eb2 link true /test mysql-connector-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not write traffic files if meta exists
1 participant