Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resign owner api not processed by owner node bug #11770

Merged

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Nov 18, 2024

What problem does this PR solve?

Issue Number: close #11769

What is changed and how it works?

/api/v2/owner/resign forward to owner node

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

 `None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 18, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-18 07:33:30.42819489 +0000 UTC m=+859972.619063886: ☑️ agreed by 3AceShowHand.
  • 2024-11-18 08:06:58.702724581 +0000 UTC m=+861980.893593578: ☑️ agreed by asddongmen.

@sdojjy
Copy link
Member Author

sdojjy commented Nov 18, 2024

/retest

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1685%. Comparing base (6c8dfe8) to head (c9541c7).
Report is 64 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.5874% <100.0000%> (-1.6326%) ⬇️
dm 50.0692% <ø> (-0.9804%) ⬇️
engine 53.2336% <ø> (-10.1685%) ⬇️
Flag Coverage Δ
unit 55.1685% <100.0000%> (-2.3062%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11770        +/-   ##
================================================
- Coverage   57.4746%   55.1685%   -2.3062%     
================================================
  Files           850       1002       +152     
  Lines        126407     137399     +10992     
================================================
+ Hits          72652      75801      +3149     
- Misses        48347      56051      +7704     
- Partials       5408       5547       +139     
---- 🚨 Try these New Features:

@sdojjy
Copy link
Member Author

sdojjy commented Nov 19, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 19, 2024
@sdojjy
Copy link
Member Author

sdojjy commented Nov 19, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit 8e3b63a into pingcap:master Nov 19, 2024
28 checks passed
@sdojjy sdojjy deleted the forward-resign-owner-api-to-owner-node branch November 19, 2024 12:48
@sdojjy sdojjy added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Nov 20, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 20, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 20, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11778.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11779.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #11780.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11781.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 20, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11782.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resign owner v2 api many not processed by owner
5 participants