Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: fix integration test in rocky8.9 #11751

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

River2000i
Copy link
Contributor

@River2000i River2000i commented Nov 15, 2024

What problem does this PR solve?

Issue Number: close #11752

What is changed and how it works?

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/dm Issues or PRs related to DM. labels Nov 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign d3hunter for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2024

Hi @River2000i. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2024
@purelind
Copy link
Collaborator

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1656%. Comparing base (b2a4f9a) to head (3966225).
Report is 4 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.6051% <ø> (+0.0295%) ⬆️
dm 50.0461% <ø> (+0.0096%) ⬆️
engine 53.2110% <ø> (-0.0283%) ⬇️
Flag Coverage Δ
unit 55.1656% <ø> (+0.0145%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11751        +/-   ##
================================================
+ Coverage   55.1510%   55.1656%   +0.0145%     
================================================
  Files          1002       1002                
  Lines        137399     137399                
================================================
+ Hits          75777      75797        +20     
+ Misses        56074      56060        -14     
+ Partials       5548       5542         -6     
---- 🚨 Try these New Features:

@River2000i
Copy link
Contributor Author

/retest
not relate fail

"Message": "startLocation: [position: (dm-it-d057503c-049a-4b78-8f1f-52dd03595422-b19zl-29htb-bin.000001, 42228), gtid-set: 013005f3-a328-11ef-a043-827aabe578a7:1-194], endLocation: [position: (dm-it-d057503c-049a-4b78-8f1f-52dd03595422-b19zl-29htb-bin.000001, 42353), gtid-set: 013005f3-a328-11ef-a043-827aabe578a7:1-195], origin SQL: [alter table shardddl1.tb1 add column b int after a]: fail to do etcd txn operation: txn commit failed",

@River2000i River2000i changed the title [wip] dm: install python dependency for test [wip] dm: install python dependency for integration test Nov 15, 2024
@River2000i
Copy link
Contributor Author

/retest
not relate fail

  • mkdir /home/jenkins/agent/workspace/pingcap/tiflow/pull_dm_integration_test/mysql-ssl
  • cp -r /var/lib/mysql/.pem /home/jenkins/agent/workspace/pingcap/tiflow/pull_dm_integration_test/mysql-ssl/
    cp: cannot stat '/var/lib/mysql/
    .pem': No such file or directory
    script returned exit code 1

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
@River2000i River2000i changed the title [wip] dm: install python dependency for integration test [wip] dm: fix integration test in rocky8.9 Nov 18, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2024
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 20, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2024
@@ -34,12 +34,18 @@ EOF
--data-dir "$WORK_DIR/pd" &
# wait until PD is online...
i=0
while ! curl "http://$PD_ADDR/pd/api/v1/version"; do
while true; do
response=$(curl -s -o /dev/null -w "%{http_code}" "http://$PD_ADDR/pd/api/v1/version")
Copy link
Contributor Author

@River2000i River2000i Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. validate http code instead of curl success or not. Since curl get success but may get [PD:server:ErrServerNotStarted]server not started
  2. sleep for waiting for port listening. Since curl may failure by Connection refused (7) then the test failure

@River2000i River2000i changed the title [wip] dm: fix integration test in rocky8.9 dm: fix integration test in rocky8.9 Nov 21, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
@River2000i
Copy link
Contributor Author

/retest

@@ -1,7 +1,7 @@
#!/bin/bash
# tools to run a TiDB cluster
# parameter 1: work directory
set -eu
set -ux
Copy link
Contributor Author

@River2000i River2000i Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip check error for start tikv fail for unknow reason like below, but tikv log didn't show any error.

+ sleep 10
+ bin/tikv-server --pd 127.0.0.1:2379 -A 127.0.0.1:2016 --status-addr 127.0.0.1:2018 --log-file /tmp/dm_test/many_tables/tikv.log --log-level info -s /tmp/dm_test/many_tables/tikv
script returned exit code 2+ ls /tmp/dm_test

Also all command have checked error.

@River2000i
Copy link
Contributor Author

/retest

@River2000i
Copy link
Contributor Author

/retest

@purelind
Copy link
Collaborator

/test dm-integration-test

@purelind
Copy link
Collaborator

/test cdc-integration-kafka-test dm-integration-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. contribution This PR is from a community contributor. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dm integration need install dependency
2 participants