-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm: fix integration test in rocky8.9 #11751
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @River2000i. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11751 +/- ##
================================================
+ Coverage 55.1510% 55.1656% +0.0145%
================================================
Files 1002 1002
Lines 137399 137399
================================================
+ Hits 75777 75797 +20
+ Misses 56074 56060 -14
+ Partials 5548 5542 -6
|
/retest
|
/retest
|
@@ -34,12 +34,18 @@ EOF | |||
--data-dir "$WORK_DIR/pd" & | |||
# wait until PD is online... | |||
i=0 | |||
while ! curl "http://$PD_ADDR/pd/api/v1/version"; do | |||
while true; do | |||
response=$(curl -s -o /dev/null -w "%{http_code}" "http://$PD_ADDR/pd/api/v1/version") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- validate http code instead of curl success or not. Since curl get success but may get
[PD:server:ErrServerNotStarted]server not started
- sleep for waiting for port listening. Since curl may failure by
Connection refused (7)
then the test failure
/retest |
@@ -1,7 +1,7 @@ | |||
#!/bin/bash | |||
# tools to run a TiDB cluster | |||
# parameter 1: work directory | |||
set -eu | |||
set -ux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip check error for start tikv fail for unknow reason like below, but tikv log didn't show any error.
+ sleep 10
+ bin/tikv-server --pd 127.0.0.1:2379 -A 127.0.0.1:2016 --status-addr 127.0.0.1:2018 --log-file /tmp/dm_test/many_tables/tikv.log --log-level info -s /tmp/dm_test/many_tables/tikv
script returned exit code 2+ ls /tmp/dm_test
Also all command have checked error.
/retest |
/retest |
/test dm-integration-test |
/test cdc-integration-kafka-test dm-integration-test |
What problem does this PR solve?
Issue Number: close #11752
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note