Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: merge dm on cloud accelerate chunk related code into master #10441

Closed
wants to merge 5 commits into from

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Jan 10, 2024

What problem does this PR solve?

Issue Number: ref #9230

What is changed and how it works?

  1. ignore gcp not exist error when we use external storage to delete all files
  2. adjust checkpoint to mysql when we use s3/gcs storage
  3. skip load table structure for S3 loader

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lichunzhu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 10, 2024

@lichunzhu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-mysql-test b066585 link true /test cdc-integration-mysql-test
pull-cdc-integration-kafka-test b066585 link true /test cdc-integration-kafka-test
pull-cdc-integration-storage-test b066585 link true /test cdc-integration-storage-test
pull-dm-compatibility-test b066585 link true /test dm-compatibility-test
jenkins-ticdc/verify b066585 link true /test verify
pull-dm-integration-test b066585 link true /test dm-integration-test
pull-engine-integration-test b066585 link true /test engine-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 10, 2024
@lichunzhu lichunzhu closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant