Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9433
Problem Summary:
What is changed and how it works?
The same as #9672, this pr refine na semi join so each
NASemiJoinHelper::doJoin()
only handle at mostmax_block_size
's data.And this pr also remove cancellation check inside
NASemiJoinHelper
andSemiJoinHelper
since now all the method inNASemiJoinHelper/SemiJoinHelper
will handle at mostmax_block_size
's data, so there is no need to check cancellation inside them.Check List
Tests
Side effects
Documentation
Release note