Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tiflash assert failure #9456

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #9430

Problem Summary:

What is changed and how it works?

Set cancellation hook after dry run of join->joinBlock so the dry run will always get a meaningfull block


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: xufei <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2024
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 03:01:16.040018973 +0000 UTC m=+1448545.780442926: ☑️ agreed by yibin87.
  • 2024-09-23 03:12:53.949493177 +0000 UTC m=+1449243.689917117: ☑️ agreed by gengliqi.

@ti-chi-bot ti-chi-bot bot merged commit 78bd3f0 into pingcap:master Sep 23, 2024
5 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9457.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 23, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9458.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 23, 2024
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9459.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 23, 2024
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9460.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 23, 2024
12 tasks
windtalker added a commit to ti-chi-bot/tiflash that referenced this pull request Sep 23, 2024
windtalker added a commit to ti-chi-bot/tiflash that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants