-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: Support a dedicated log file to save general log #51249
Conversation
2. update `--log-general` 3. update compress
Hi @Defined2014. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51249 +/- ##
================================================
+ Coverage 72.4732% 72.7753% +0.3021%
================================================
Files 1475 1476 +1
Lines 363671 439513 +75842
================================================
+ Hits 263564 319857 +56293
- Misses 80719 99671 +18952
- Partials 19388 19985 +597
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test check-dev2 |
@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, tiancaiamao, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #51248
Problem Summary:
What changed and how does it work?
Check List
Tests
Test normal log with dashboard
Test slow query with dashboard, could found the first slow query in compressed file.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.