Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: Support a dedicated log file to save general log #51249

Merged
merged 20 commits into from
Mar 14, 2024

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Feb 22, 2024

What problem does this PR solve?

Issue Number: ref #51248

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Test normal log with dashboard
image
image

Test slow query with dashboard, could found the first slow query in compressed file.
image
image

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
When compression is enabled, it slows down log searches in the dashboard and also affects queries performance to the `cluster_slow_query` table.
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

2. update `--log-general`
3. update compress
@Defined2014 Defined2014 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 22, 2024
Copy link

tiprow bot commented Feb 22, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 22, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Merging #51249 (c37deda) into master (0d742d3) will increase coverage by 0.3021%.
Report is 11 commits behind head on master.
The diff coverage is 78.8617%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51249        +/-   ##
================================================
+ Coverage   72.4732%   72.7753%   +0.3021%     
================================================
  Files          1475       1476         +1     
  Lines        363671     439513     +75842     
================================================
+ Hits         263564     319857     +56293     
- Misses        80719      99671     +18952     
- Partials      19388      19985       +597     
Flag Coverage Δ
integration 48.8822% <27.6422%> (?)
unit 70.6041% <78.8617%> (-1.7596%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 50.9619% <ø> (+4.5526%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 12, 2024
@Defined2014
Copy link
Contributor Author

/test check-dev2

Copy link

tiprow bot commented Mar 12, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 12, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 13, 2024
Copy link

ti-chi-bot bot commented Mar 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-12 11:08:22.313344569 +0000 UTC m=+770129.335590958: ☑️ agreed by xhebox.
  • 2024-03-13 03:58:18.686288422 +0000 UTC m=+830725.708534809: ☑️ agreed by tiancaiamao.

@easonn7
Copy link

easonn7 commented Mar 14, 2024

/approve

Copy link

ti-chi-bot bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, tiancaiamao, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 14, 2024
@Defined2014 Defined2014 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
@Defined2014 Defined2014 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9545923 into pingcap:master Mar 14, 2024
21 checks passed
@Defined2014 Defined2014 deleted the general-log branch March 29, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants