-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync_diff_inspector: add sum aggregate #686
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
rest lgtm |
Signed-off-by: Leavrth <[email protected]>
Co-authored-by: 3pointer <[email protected]>
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
Signed-off-by: Leavrth <[email protected]>
@Leavrth: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: ref #634
What is changed and how it works?
we can choose
SUM
as the aggregate operator instead ofBIT_XOR
.Check List
Tests