Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slog and slog-global #375

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

CalvinNeo
Copy link
Member

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:


Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note


Signed-off-by: CalvinNeo <[email protected]>
@JaySon-Huang
Copy link
Collaborator

  1. Can you elaborate why this will make the "Welcome to ..." is not print?
  2. Seem the Cargo.lock need to be updated https://prow.tidb.net/view/gs/prow-tidb-logs/pr-logs/pull/pingcap_tidb-engine-ext/375/pull-unit-test/1803452067159740416
make[1]: Leaving directory `/home/prow/go/src/github.com/pingcap/tidb-engine-ext'
++ git status -s .
 M Cargo.lock
+++ git status -s .
++ GIT_STATUS=' M Cargo.lock'
++ [[ -n  M Cargo.lock ]]
++ echo 'Error: found illegal git status'
Error: found illegal git status
++ echo M Cargo.lock
M Cargo.lock
++ [[ -z  M Cargo.lock ]]
make: *** [ci_fmt_check] Error 1

Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L and removed size/S labels Jun 20, 2024
Copy link

ti-chi-bot bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 20, 2024
Copy link

ti-chi-bot bot commented Jun 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-20 05:48:15.059349254 +0000 UTC m=+266621.544838086: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit b8c00d3 into pingcap:raftstore-proxy Jun 20, 2024
4 checks passed
@CalvinNeo
Copy link
Member Author

  1. Can you elaborate why this will make the "Welcome to ..." is not print?
  2. Seem the Cargo.lock need to be updated https://prow.tidb.net/view/gs/prow-tidb-logs/pr-logs/pull/pingcap_tidb-engine-ext/375/pull-unit-test/1803452067159740416
make[1]: Leaving directory `/home/prow/go/src/github.com/pingcap/tidb-engine-ext'
++ git status -s .
 M Cargo.lock
+++ git status -s .
++ GIT_STATUS=' M Cargo.lock'
++ [[ -n  M Cargo.lock ]]
++ echo 'Error: found illegal git status'
Error: found illegal git status
++ echo M Cargo.lock
M Cargo.lock
++ [[ -z  M Cargo.lock ]]
make: *** [ci_fmt_check] Error 1

https://stackoverflow.com/questions/78645477/what-happens-if-i-introduce-the-same-dependency-after-i-have-introduced-a-worksp?noredirect=1#comment138656387_78645477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants