Depend on raft-proto crate instead of raft #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoverbear
reviewed
Jun 19, 2019
We now only depend on crates.io crates, cc pingcap#280 Signed-off-by: Nick Cameron <[email protected]>
Fixes a bunch of warnings Signed-off-by: Nick Cameron <[email protected]>
Hoverbear
reviewed
Jun 25, 2019
| @@ -19,7 +19,7 @@ prost-derive = "0.5" | |||
| bytes = "0.4" | |||
| futures = "0.1" | |||
| grpcio = { version = "0.5.0-alpha.1", features = ["prost-codec"] } | |||
| raft = { git = "https://github.com/pingcap/raft-rs.git", rev = "8e953b0d0c9cd2f98c94a42edc48ae3f09e967ff" } | |||
| raft-proto = "0.4" | |||
There was a problem hiding this comment.
Can you explain the versioning strategy you expect?
There was a problem hiding this comment.
Yes, matching with Raft. (Although if we do something different, it doesn't matter much).
ice1000
approved these changes
Jun 25, 2019
BusyJay
approved these changes
Jun 26, 2019
I'd be happy to have that setup. Do you know why we build into src at the moment? |
|
@nrc Please, go ahead :) |
sticnarf
pushed a commit
to sticnarf/kvproto
that referenced
this pull request
Oct 27, 2019
* Use the raft-proto crate instead of raft We now only depend on crates.io crates, cc pingcap#280 Signed-off-by: Nick Cameron <[email protected]> * Update protobuf-build Fixes a bunch of warnings Signed-off-by: Nick Cameron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Means we don't need a Git dependency and can publish KvProto on crates.io (#280).
Also re-generates the Prost code to avoid hundreds of warnings.
PTAL @Hoverbear @BusyJay