Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb: add general-log-file and compression #16719

Merged
merged 21 commits into from
Mar 19, 2024
Merged

tidb: add general-log-file and compression #16719

merged 21 commits into from
Mar 19, 2024

Conversation

Defined2014
Copy link
Contributor

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Defined2014 Defined2014 mentioned this pull request Mar 1, 2024
Closed
4 tasks
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 1, 2024
@hfxsd hfxsd self-assigned this Mar 1, 2024
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. v8.0 This PR/issue applies to TiDB v8.0. and removed missing-translation-status This PR does not have translation status info. labels Mar 1, 2024
@hfxsd hfxsd requested review from hfxsd and bb7133 March 1, 2024 06:36
hfxsd
hfxsd reviewed Mar 1, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Mar 1, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Mar 1, 2024
@hfxsd hfxsd changed the title log: update log related config tidb: add general-log-file and compress Mar 1, 2024
hfxsd
hfxsd reviewed Mar 1, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Mar 1, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Mar 1, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Mar 1, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Mar 1, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
@hfxsd hfxsd mentioned this pull request Mar 1, 2024
Merged
18 tasks
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 4, 2024

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Oreoxmt
Oreoxmt reviewed Mar 5, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
bb7133
bb7133 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 5, 2024

@bb7133: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014 Defined2014 changed the title tidb: add general-log-file and compress tidb: add general-log-file and compression Mar 14, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 14, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-01 07:21:17.145130972 +0000 UTC m=+1205765.892754082: ☑️ agreed by hfxsd.
  • 2024-03-14 03:58:56.195066974 +0000 UTC m=+917163.217313359: ☑️ agreed by Oreoxmt.

hfxsd
hfxsd reviewed Mar 15, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Mar 19, 2024
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
@hfxsd
Copy link
Collaborator

hfxsd commented Mar 19, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit a21a726 into pingcap:master Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@songrijie songrijie songrijie approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.0 This PR/issue applies to TiDB v8.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Defined2014 @hfxsd @bb7133 @songrijie @Oreoxmt