upgrade markdown to 3.1.1 #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @KatherineMichel Could you please review this PR? Thank you! |
tartieret
approved these changes
Sep 2, 2021
|
I run into the same conflict with dependencies, could we finalize and merge this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # #117
Changes proposed in this PR:
Upgrade the dependency on markdown and fix the startup issues that led to this upgrade being reverted. Many modern Django apps (such as django-wiki) require a higher version of Markdown. This makes it possible to use the pinax-blog in sites that also use such apps (like https://www.thecontractrpg.com !)