This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Clehner/maximize views #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 21, 2018 11:31
…e content is not shown correctly and tabs cannot be switched, since event listeners are not copied
thinkh
reviewed
Feb 26, 2018
|
yes, the margin is still an issue further changes I'll make:
|
|
Your suggested changes sound good to me. |
|
suggested changes implemented: |
|
very nice, looks great! |
thinkh
reviewed
Feb 26, 2018
src/layout/interfaces.ts
Outdated
| @@ -19,7 +19,7 @@ export class LayoutContainerEvents { | |||
| static readonly EVENT_TAB_REORDED = 'tabReorded'; | |||
| static readonly EVENT_CHANGE_ACTIVE_TAB = 'changeActiveTab'; | |||
| static readonly EVENT_MAXIMIZE = 'maximize'; | |||
| static readonly EVENT_MINIMIZE = 'minimize'; | |||
| static readonly RESTORE_SIZE = 'restoreSize'; | |||
There was a problem hiding this comment.
Why don't you keep the EVENT_ at the beginning of the variable name?
sgratzl
reviewed
Feb 26, 2018
| constructor(document: Document, public readonly build: (layout: IBuildAbleOrViewLike)=> ILayoutContainer, private readonly restorer: (dump: ILayoutDump, restoreView: (referenceId: number) => IView) => ILayoutContainer) { | ||
| super(document, { | ||
| name: '', | ||
| fixed: true | ||
| }); | ||
| this.node.dataset.layout = 'root'; | ||
| this.visible = true; | ||
|
|
||
| this.on(LayoutContainerEvents.EVENT_MAXIMIZE, (evt) => { |
| // maximize views | ||
| const view = evt.args[0]; | ||
|
|
||
| const section = document.createElement('section'); |
There was a problem hiding this comment.
prefer: this.node.ownerDocument.createElement
| @@ -18,6 +18,8 @@ export default class ViewLayoutContainer extends ALayoutContainer<IViewLayoutCon | |||
| this.node.dataset.layout = 'view'; | |||
| this.node.appendChild(view.node); | |||
|
|
|||
| this.header.insertAdjacentHTML('beforeend', `<button type="button" title="Expand view" class="size-toggle ${this.options.fixed ? 'hidden' : ''}" aria-label="Toggle View Size"><span><i class="fa fa-expand"></i></span></button>`); | |||
There was a problem hiding this comment.
when the layout is fixed, I cannot maximize the view?
added 9 commits
February 27, 2018 08:01
…iew dump instead of view.parent since it could be organized differently and therefore the nodes would be added somewhere else
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #51