Quick fix for race condition in JS.show()

phoenixframework · Oct 5, 2024 · 31dc9e6 · 31dc9e6
1 parent d9cbbe9
commit 31dc9e6
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/assets/js/phoenix_live_view/js.js b/assets/js/phoenix_live_view/js.js
@@ -190,11 +190,13 @@ let JS = {
         if(eventType === "remove"){ return }
         let onStart = () => {
           this.addOrRemoveClasses(el, inStartClasses, outClasses.concat(outStartClasses).concat(outEndClasses))
-          let stickyDisplay = display || this.defaultDisplay(el)
-          DOM.putSticky(el, "toggle", currentEl => currentEl.style.display = stickyDisplay)
           window.requestAnimationFrame(() => {
             this.addOrRemoveClasses(el, inClasses, [])
-            window.requestAnimationFrame(() => this.addOrRemoveClasses(el, inEndClasses, inStartClasses))
+            window.requestAnimationFrame(() => {
+              this.addOrRemoveClasses(el, inEndClasses, inStartClasses)
+              let stickyDisplay = display || this.defaultDisplay(el)
+              DOM.putSticky(el, "toggle", currentEl => currentEl.style.display = stickyDisplay)
+            })
           })
         }
         let onEnd = () => {