Fixes and Tests for Issues #5, #6 and #7 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanlm
requested changes
Mar 25, 2020
| @@ -7,6 +7,24 @@ Class { | |||
| #category : #'MySQL-Core-Tests-Integration-Base' | |||
| } | |||
|
|
|||
| { #category : #tests } | |||
| MySQLServerStatementFetchTest >> _testReadNextRow [ | |||
There was a problem hiding this comment.
this kind of name is not at all how conventions are (the underscore).
can you suggest a better name?
There was a problem hiding this comment.
Thanks for the comment; have rewritten the test cases longhand as that seems to be the general pattern elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the suggested fixes discussed in issues #5, #6 and #7.
Add test cases for these issues; updating existing tests to reflect changes.
All tests run green.