Pull Request by Zilin Huang regarding Issue #222 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ddsjoberg
reviewed
Oct 21, 2024
Comment on lines
+58
to
+65
| # Generate an error if the input is a `survfit.coxphms` regression model: ---- | ||
| if (inherits(x, "survfitcoxms")) { | ||
| cli_abort( | ||
| "Argument {.arg x} does not support {.cls survfit.coxphms} object. | ||
| Please fit a multi-state model with another project, such as {.fn coxph}." | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
Please use the simplified text we discussed here.
ddsjoberg
reviewed
Oct 21, 2024
R/ggcuminc.R
Outdated
| @@ -69,8 +77,9 @@ ggcuminc <- function(x, outcome = NULL, | |||
| cli_inform("Plotting outcome {.val {outcome}}.") | |||
| } | |||
| if (any(!outcome %in% unique(df$outcome))) { | |||
| cli_abort("Argument {.code outcome} must be one or more of {.val {unique(df$outcome)}}") | |||
| cli_abort("Argument {.arg x} does not support {.cls survfit.coxphms} object.") | |||
There was a problem hiding this comment.
I don't understand this change to the error message. Was this intentional?
ddsjoberg
reviewed
Oct 21, 2024
R/scale_ggsurvfit.R
Outdated
| @@ -34,6 +34,8 @@ | |||
| #' # specify additional scales | |||
| #' ggsurvfit + | |||
| #' scale_ggsurvfit(x_scales = list(breaks = seq(0, 8, by = 2))) | |||
| #' | |||
|
|
|||
There was a problem hiding this comment.
was this spacing addition intentional/needed? if not, can you please revert
There was a problem hiding this comment.
@ddsjoberg I have reverted it back (probably add this space by accident). Thanks for reminding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #222 by updating the error message.