Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solve the error in bot creation #482

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: solve the error in bot creation #482

merged 2 commits into from
Nov 18, 2024

Conversation

xingwanying
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
petercat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:03am

Copy link

Walkthrough

This pull request addresses an error in bot creation by refactoring the bot creation logic. It introduces changes to the bot creation parameters, ensuring that language and repository name are correctly handled. Additionally, it updates the bot's greeting and starter messages to be dynamically generated based on the language.

Changes

File Summary
assistant/src/Chat/index.tsx Removed redundant bot introduction message.
assistant/src/mock/bot.mock.ts Reformatted bot's hello message and starter questions.
client/app/factory/edit/page.tsx Modified bot creation call to include language parameter.
client/app/services/BotsController.ts Refactored createBot function to accept a parameter object.
server/agent/bot/bot_builder.py Minor formatting changes.
server/agent/prompts/bot_builder.py Enhanced prompt generation logic to include more starter questions.
server/bot/router.py Refactored bot creation endpoint to handle default messages and starters based on language.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
server/bot/router.py 0.00% 8 Missing ⚠️
server/agent/bot/bot_builder.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
server/agent/prompts/bot_builder.py 57.14% <ø> (ø)
server/agent/bot/bot_builder.py 72.72% <0.00%> (ø)
server/bot/router.py 19.68% <0.00%> (-0.43%) ⬇️

... and 1 file with indirect coverage changes

@xingwanying xingwanying merged commit 40a41c2 into main Nov 18, 2024
4 of 5 checks passed
@xingwanying xingwanying deleted the fix_bot_builder branch November 18, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant