Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix finegrained roles #268

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix finegrained roles #268

wants to merge 6 commits into from

Conversation

julianweng
Copy link
Member

Fixes #266 feature and merges on #267

  • Deletes template member as all members must now be part of at least one team for the site to build, which necessarily displays the member
  • Displays semester joined in each member card again
  • No longer has smaller cards for first or second team (I'm pretty sure this was an existing bug, but should be fixed now?)

@julianweng julianweng requested a review from joyliu-q May 15, 2024 20:17
Clue88
Clue88 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@Clue88 Clue88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to add some screenshots to the PR for future reference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clue88 Clue88 Clue88 approved these changes

@joyliu-q joyliu-q Awaiting requested review from joyliu-q

@anli5005 anli5005 Awaiting requested review from anli5005

@rohangpta rohangpta Awaiting requested review from rohangpta

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianweng @Clue88