Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications] Add APNS and FCM Credentials #331

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

joyliu-q
Copy link
Contributor

Path to credentials sent on slack. They are in /app but so is the ios-key, so we can just migrate them altogether eventually.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.64%. Comparing base (b806dc7) to head (afc92e6).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   89.60%   89.64%   +0.03%     
==========================================
  Files          67       67              
  Lines        2704     2704              
==========================================
+ Hits         2423     2424       +1     
+ Misses        281      280       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@joyliu-q joyliu-q merged commit ccb5db2 into master Nov 19, 2024
9 checks passed
@joyliu-q joyliu-q deleted the joy/allegedly-add-secrets branch November 19, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant