Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #11 - quick word cloud of swear words of reddit comments #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarcinKosinski
Copy link
Collaborator

image

@pdrhlik very quick application that boosted Suggests section I am not proud of. One would need to extend the vignette with some explanatory text that describes the code. Then such a vignette can be listed as an article if we ever go for bookdown pages, like this one http://www.sthda.com/english/rpkgs/survminer/articles/index.html

Copy link
Owner

@pdrhlik pdrhlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great start! There are just a few comments I want you to go over. How do you structure the vignettes folder? Wouldn't it be better to create a folder for each vignette? It might get pretty messy when there are more like these. I honestly don't know the 'right' way to do this.

@@ -1,20 +1,24 @@
Package: sweary
Type: Package
Title: Database of Swear Words in R
Version: 0.0.0.9000
Version: 0.0.0.9001
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't change development versions. It moves pretty fast. I would keep this 0.0.0.9000 until ve decide on releasing something like v0.1.



```{r}
library(sweary);library(dplyr)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the library calls on separate lines.

count(word)
```

```{r}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing library(wordcloud2) here.


```{r}
library(RedditExtractoR)
reddit_comments <-
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of code produces a lot of mess while downloading the comments.

|
| | 0%
|
|====== | 4%
|
|=========== | 8%

We don't want that in the vignette.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants