Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ipymesh example #10

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Added ipymesh example #10

wants to merge 8 commits into from

Conversation

cekees
Copy link

@cekees cekees commented Jun 6, 2019

The purpose of this example is to show how the ipymesh mesh editor widget works by building a simple computational geometry builder and mesh generator app. The bqplot plotting of the mesh could use some improvement to actually display the classification of the mesh. The segment colors aren't right, and it would also be nice to use an opaque fill on the triangles to illustrate the partitioning into regions and holes, possibly also the boundary vertex coloring. Thanks @pbugnion for setting up the gallery!

/cc @SylvainCorlay @maartenbreddels @jasongrout

@cekees
Copy link
Author

cekees commented Jun 6, 2019

I updated the README on my repo to test on mybinder. It's working! BTW, I'm not currently able to run either binder or the voila server on your repo @pbugnion. I've tried hard reloads and clearing the cache on my chrome browser. I'm not actually seeing errors in the javascript console. I see some markdown cell output in some of the examples but no interactive widgets.

@pbugnion
Copy link
Owner

pbugnion commented Jun 9, 2019

Hi Chris!

Thanks a lot for submitting this. It looks great!

Thanks to Yuvi, we've actually migrated to a more robust deployment of voila-gallery here. This leverages JupyterHub and each example runs in its own docker container, so you could, in principle, run proteus if you can make it work on binder.

I'm happy to either:

Let me know what you think.

@cekees
Copy link
Author

cekees commented Jun 9, 2019

The new approach looks nice! I like having individual repositories and docker containers for each example. I'll migrate this over as well as another example using leaflet that have very simple stacks. Proteus also works on binder but is slow to load due to the size of the image. I'll try an example but will likely have to do some work on optimizing the docker container.

@cekees
Copy link
Author

cekees commented Jun 10, 2019

I didn't get around to moving to this over to the new setup, but I did finish another meshing application using ipyleaflet. For the new setup, the repositories for each app can be in cekees or erdc repositories, right?

@pbugnion
Copy link
Owner

I didn't get around to moving to this over to the new setup, but I did finish another meshing application using ipyleaflet.

Great! That'd be awesome.

For the new setup, the repositories for each app can be in cekees or erdc repositories, right?

Yes! The repo can be anywhere. To test that it can be integrated with voila-gallery, you can check that it works in binder (since both use repo2docker to build the images).

I'd say the only restriction is that the repo should have a permissive license, like MIT or 3 clause BSD. I haven't added this to the existing examples, but I plan to.

If I can help try anything out, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants