Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtitle merge of an empty caption #238

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Jul 1, 2021

  1. Fix subtitle merge of empty caption

    This fix the error: 
    AttributeError: 'NoneType' object has no attribute 'start'
    
    Explaining the error:
    It is caused because the caption has a blank value, a blank caption with no text, this causes the default code that joins the subtitles to go into error, as it cannot join a received None value, with an existing String value, and ends up breaking the subtitle conversion.
    
    Problem example (DFXP/SMPTE xml):
    ```<p region='pop1' style='basic' begin='01:55:05:08' end='01:55:11:14' tts:origin='17.5% 84.66%' tts:extent='62.5% 5.33%'>Subtitle End</p>
    <p region='pop2' style='basic' begin='01:55:05:08' end='01:55:11:14' tts:origin='50% 84.66%' tts:extent='0% 5.33%'></p>```
    FloridaStream authored Jul 1, 2021
    Configuration menu
    Copy the full SHA
    5d39b6d View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. Fix merge_concurrent_captions

    Fix merge of an empty caption
    FloridaStream authored Jul 2, 2021
    Configuration menu
    Copy the full SHA
    53c2dd2 View commit details
    Browse the repository at this point in the history