Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hooks optional #1672

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Make hooks optional #1672

merged 1 commit into from
Aug 12, 2024

Commits on Aug 6, 2024

  1. Make hooks optional

    This changes the default setting of the 'hooksfile' setting
    and associated behaviour so that, unless explicitly set,
    this config setting defaults to `None`, which then means loading the
    hooksfile is not even attempted.
    
    Prior to this commit, the default value was
    `$XDG_CONFIG_HOME/alot/hooks.py`
    and no alot would try to read that file upon start (and report via
    logging.exception if it failed, which in the ui is uncritical).
    
    This was problematic not only in that it hardcodes the unix separator
    '/' but also because it caused unecessary disk access / errors.
    More importantly, it caused several test cases to fail (see
    [here](https://bugs.gentoo.org/874372#c2).
    
    The patch also includes updated docs.
    Patrick Totzke committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    7259842 View commit details
    Browse the repository at this point in the history