This repository has been archived by the owner on Jul 20, 2020. It is now read-only.
[#47] Unittests Part1 #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the PR Quality Review checks? |
pauljv92
force-pushed
the
testcases_part1
branch
2 times, most recently
from
082e78b
to
efb32e4
Compare
pauljv92
force-pushed
the
testcases_part1
branch
from
efb32e4
to
546c4ac
Compare
|
@praveenkanamarlapudi done! |
tests/test_ppsql_hiveconnection.py
Outdated
| @@ -3,7 +3,7 @@ | |||
| import unittest | |||
|
|
|||
| class TestPPSqlHiveConnection(unittest.TestCase): | |||
|
|
|||
There was a problem hiding this comment.
NIT - can we avoid these changes
praveen-kanamarlapudi
requested review from
ayushiagarwal and
aashish-sheshadri
|
@pauljv92 Can you rebase and update the PR? |
|
@praveenkanamarlapudi sure will do! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
GitHub Issue
Fixes #47
Checklist:
What is the purpose of this pull request?
Part 1 of Unittests
How was this change validated?
Run with these commands: ipython -c "import nose; nose.run()" AND nosetests --with-coverage --cover-package=ppextensions/
Commit Guidelines