Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list stream permission to all roles #464

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Aug 3, 2023

Description

All roles can list stream. The response is not specialized, thus any client of the api has to check for response of GET logstream/{}/schema to know if the user has access to it


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht self-requested a review August 3, 2023 15:38
@nitisht nitisht merged commit 6d227ed into parseablehq:main Aug 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2023
@trueleo trueleo deleted the role_fix branch August 7, 2023 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants