Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with untrimmed command #844

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

bambamboole
Copy link

After update to PHP 8.3 I got the following warnings in the bin/phpunit-wrapper.php:

Warning: unserialize(): Extra data starting at offset 534 of 535 bytes in /Users/xxx/Projects/xxx/vendor/brianium/paratest/bin/phpunit-wrapper.php on line 41

Trimming the command helped there.

@Slamdunk
Copy link
Member

Can you add a test please?

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (8083a42) to head (3e7115c).

Additional details and impacted files
@@            Coverage Diff            @@
##                6.x     #844   +/-   ##
=========================================
  Coverage     99.77%   99.77%           
  Complexity      632      632           
=========================================
  Files            31       31           
  Lines          2207     2207           
=========================================
  Hits           2202     2202           
  Misses            5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bambamboole
Copy link
Author

@Slamdunk , maybe you can support me here, because I am having a hard time reproducing this in a test case. First of all I have extended now the CI test suite to also run on PHP 8.3. But how can I assert such a case in a bast way?
I "believe", that the error in general comes from the case, that PHP8.3 throws a warning like Warning: unserialize(): Extra data star... and because of that additional output the execution fails.

@Slamdunk
Copy link
Member

I see only now that this PR targets 6.x branch: it's EOLed and I don't care much anymore, so I'll merge and release this as is.

Thank you for your contribution.

@Slamdunk Slamdunk merged commit 78e297a into paratestphp:6.x Mar 13, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants