Review feedback #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcSkovMadsen
commented
Nov 23, 2024
Closed
Closed
ahuang11
reviewed
Nov 24, 2024
ahuang11
reviewed
Nov 24, 2024
ahuang11
reviewed
Nov 24, 2024
ahuang11
reviewed
Nov 24, 2024
ahuang11
reviewed
Nov 24, 2024
ahuang11
reviewed
Nov 24, 2024
|
Thanks! I support these changes; I think just need to fix the linting, and if you're up for it, fixing the other CI (if not I can take a deeper look later and we can first merge this PR). |
Co-authored-by: Andrew <[email protected]>
Co-authored-by: Andrew <[email protected]>
Co-authored-by: Andrew <[email protected]>
Co-authored-by: Andrew <[email protected]>
Co-authored-by: Andrew <[email protected]>
…l-extensions/copier-template-panel-extension into enhancement/review-feedback
|
Users should select "Github Actions" to avoid also building docs via jekyll and sometimes publishing thoses. |
|
I looked through the failing tests. Its not obvious to me that they are related to this PR? |
Closed
|
Correct it's unrelated. Will review this later and merge! |
ahuang11
reviewed
Nov 25, 2024
ahuang11
reviewed
Nov 25, 2024
README.md
Outdated
Comment on lines
48
to
50
| On your GitHub repo's **About** section in the sidebar, be sure to add the link to your docs page: | ||
|
|
||
| On your GitHub repo's sidebar's About section, be sure to add the link to your docs page and some tags! | ||
| https://<github-user>.github.io/<panel-extension-name>/ |
There was a problem hiding this comment.
I think there's a button to automatically use the GitHub page.
There was a problem hiding this comment.
I'm not sure I understand. Could you make the change?
ahuang11
reviewed
Nov 25, 2024
ahuang11
approved these changes
Nov 25, 2024
Co-authored-by: Andrew <[email protected]>
ahuang11
reviewed
Nov 25, 2024
|
Thanks for helping me improve this significantly! |
|
Thanks for creating this amazing piece of art! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project is awesome!
Here is my feedback based on using it to create https://github.com/awesome-panel/panel-copy-paste.