[P1][Beta] Fix phazing moves forcing switches into fainted/ineligible Pokemon #4951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Phazing moves can no longer randomly choose to force a switch into a fainted/ineligible Pokemon.
Also, phazing moves properly use seeded RNG instead of unseeded RNG.
Why am I making these changes?
Bug report: Discord
What are the changes from a developer perspective?
Screenshots/Videos
Before the changes: Phazing moves can force a switch into a fainted Pokemon
20241129.Before.Fix.Phazing.mp4
After the changes: Phazing moves no longer force a switch into a fainted Pokemon
20241129.After.Fix.Phazing.mp4
How to test the changes?
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?[ ] Have I made sure that any UI change works for both UI themes (default and legacy)?Are there any localization additions or changes? If so:
[ ] Has a locales PR been created on the locales repo?[ ] If so, please leave a link to it here:[ ] Has the translation team been contacted for proofreading/translation?