-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Move] Full Stuff cheeks implementation #4941
Open
geeilhan
wants to merge
10
commits into
pagefaultgames:beta
Choose a base branch
from
geeilhan:stuff-cheeks-implementation
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Move] Full Stuff cheeks implementation #4941
geeilhan
wants to merge
10
commits into
pagefaultgames:beta
from
geeilhan:stuff-cheeks-implementation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently working on refactoring this so I use BattlerTags (MoveRestricitonBattlerTag) instead of making the move directly unselectable |
I think something is wrong with the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Stuff Cheeks is now fully implemented. (#3503)
What are the changes from a developer perspective?
Added a new class
MoveSelectCondition
insidemove.ts
which checks if a move is selectable in the move menu. It contains the condition (UserMoveConditionFunc
) that allows selecting a move.StuffCheeksCondition
extendsMoveSelectCondition
and contains the condition that fails if the user does not hold at least 1 berry. If the condition fails aStuffCheeksTag
, which extendsMoveRestrictionTag
, is added. This tag gets removed at the end of the turn.Also added
private selectableConditions: MoveSelectCondition[] = [];
which saves the condition for the move.
Screenshots/Videos
Before implementation:
stuff-cheeks-implementation-before.webm
After Implementation:
stuff-cheeks-implementation-after.webm
How to test the changes?
Added automated tests
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?