Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move] Implement Lunar Dance #4926

Open
wants to merge 5 commits into
base: beta
Choose a base branch
from

Conversation

PrabbyDD
Copy link
Contributor

@PrabbyDD PrabbyDD commented Nov 20, 2024

What are the changes the user will see?

Lunar Dance works as intended

Why am I making these changes?

build da game

What are the changes from a developer perspective?

Added variable and some code that allows similar move attr to healing wish to also allow restore of PP

Screenshots/Videos

Pokemon has its status, hp and pp returned

2024-11-20.15-08-43.mp4

No more pokemon in party

2024-11-20.15-06-45.mp4

How to test the changes?

override and future unit tests

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@PrabbyDD PrabbyDD requested a review from a team as a code owner November 20, 2024 22:41
@PrabbyDD PrabbyDD marked this pull request as draft November 20, 2024 22:41
@PrabbyDD PrabbyDD marked this pull request as ready for review November 20, 2024 23:45
@PrabbyDD
Copy link
Contributor Author

For some reason I cant add the change I made in public/locales/en/move-trigger.json - I added a message that is the same in the base games for when lunar dance triggers.

@PrabbyDD
Copy link
Contributor Author

ahh i see its a submodule, so I am not sure what to do then - do I need to contact localization team to have them add the message?

@PrabbyDD
Copy link
Contributor Author

It was just this in public/locales/en/move-trigger.json

"lunarDanceRestore" : "{{pokemonName}}'s became cloaked in mystical moonlight!",

@torranx torranx added the Move Affects a move label Nov 21, 2024
@DayKev DayKev added the Enhancement New feature or request label Dec 1, 2024
@DayKev DayKev changed the title [Move] Implementing Lunar Dance [Move] Implement Lunar Dance Dec 1, 2024
Copy link
Collaborator

@DayKev DayKev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions here PrabbyDD#2

@DayKev
Copy link
Collaborator

DayKev commented Dec 2, 2024

It was just this in public/locales/en/move-trigger.json

"lunarDanceRestore" : "{{pokemonName}}'s became cloaked in mystical moonlight!",

Locales PR created/merged. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Move Affects a move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants