-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Move] Implement Lunar Dance #4926
base: beta
Are you sure you want to change the base?
Conversation
For some reason I cant add the change I made in public/locales/en/move-trigger.json - I added a message that is the same in the base games for when lunar dance triggers. |
ahh i see its a submodule, so I am not sure what to do then - do I need to contact localization team to have them add the message? |
It was just this in public/locales/en/move-trigger.json "lunarDanceRestore" : "{{pokemonName}}'s became cloaked in mystical moonlight!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some suggestions here PrabbyDD#2
Locales PR created/merged. 👍 |
What are the changes the user will see?
Lunar Dance works as intended
Why am I making these changes?
build da game
What are the changes from a developer perspective?
Added variable and some code that allows similar move attr to healing wish to also allow restore of PP
Screenshots/Videos
Pokemon has its status, hp and pp returned
2024-11-20.15-08-43.mp4
No more pokemon in party
2024-11-20.15-06-45.mp4
How to test the changes?
override and future unit tests
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so: