Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make navtitle element from topictitle #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

PieterjanVandenweghe
Copy link

No description provided.

@raducoravu
Copy link
Contributor

@PieterjanVandenweghe thanks for wanting to make a contribution. Each pull request made to our repositories needs to have a signoff in the commit message.
Also looking in the stylesheet "SetnavtitleFromTopicTitle.xsl":

  • Maybe its name should be "SetNavtitleFromTopicTitle.xsl" in order to have consistent camel casing
  • I do not understand why this "[@Audience]" selector appears, if the XML refactoring is to work generically, for any DITA project it should not contain a project specific case.
  • There is an xsl:message which should be removed:
    <xsl:message>test</xsl:message>
  • Does this XPath actually return the DITA topic title because it seems to return the text nodes from the topic root element?
    <xsl:value-of select="document(@href)/topic[@Audience]"/>

@PieterjanVandenweghe
Copy link
Author

Hi Radu,
Thank you for the feedback.
It seems I uploaded not my latest version.
I am sorry for that, but I'll take all of the comments into account before I upload again.
Just wanted to combine two of your Refactoring scripts.

…or topicref and chapter elements.

- Update existing <navtitle> element based on the current topic title for topicref and chapter elements.
@PieterjanVandenweghe
Copy link
Author

@raducoravu If you commit via the Client Add-onn from OxygenXML, does it also automatically sign off with my default user info? Or do I have to do it manually in the commit message?

@raducoravu
Copy link
Contributor

raducoravu commented Nov 23, 2020

@PieterjanVandenweghe our Git add-on does not have any signoff specific functionality so it needs to be manually added in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants