[tests-only][full-ci] adding test for editing shared file(OCM) by the share receiver

[nirajacharya2]

Description

adding test for editing shared file(OCM) by the share receiver
bug coverage of #10358

Related Issue

• Related Issue Extend test coverage for ocm #10073

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[saw-jan]

what happens with the share param in this function? is it used in the request?

[nirajacharya2]

it is ignored.

ocis/tests/acceptance/TestHelpers/WebDavHelper.php

Lines 730 to 753 in cbe1360

	if ($path === null) {
	$path = "";
	}
	// get space id if testing with spaces dav
	if ($spaceId === null && $davPathVersionToUse === self::DAV_VERSION_SPACES && !\in_array($type, ["public-files", "versions"])) {
	$path = \ltrim($path, "/");
	if (\str_starts_with($path, "Shares/")) {
	$spaceId = self::getSharesSpaceIdForUser(
	$baseUrl,
	$user,
	$password,
	$xRequestId
	);
	$path = "/" . preg_replace("/^Shares\//", "", $path);
	} else {
	$spaceId = self::getPersonalSpaceIdForUserOrFakeIfNotFound(
	$baseUrl,
	$user,
	$password,
	$xRequestId
	);
	}
	}

but leaving it in the step can make the step more clear or i can just delete it.

[saw-jan]

this if statement should not be triggered, right? because we send some value to $spaceId

[saw-jan]

I see this url being hit:
https://localhost:10200/remote.php/dav/spaces/89f37a33-858b-45fa-8890-a1f2b27d90e1$f1c7b05d-38c4-4822-b30c-7c484b8ac287!L3RleHRmaWxlLnR4dA==/textfile.txt
but this should also work and this is what we want to do
https://localhost:10200/remote.php/dav/spaces/89f37a33-858b-45fa-8890-a1f2b27d90e1$f1c7b05d-38c4-4822-b30c-7c484b8ac287!L3RleHRmaWxlLnR4dA==/

you can send the empty string in that param

[PrajwolAmatya]

Suggested change

	$spaceId = $this->featureContext->spacesContext->getSharesRemoteItemId($user, $share);
	$spaceId = $this->getSharesRemoteItemId($user, $share);