Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] add test to list shares shared to federated user #10290

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[tests-only][full-ci] add test to list shares shared to federated user #10290

merged 1 commit into from
Oct 17, 2024

Conversation

prashant-gurung899
Copy link
Contributor

Description

This PR adds tests where the sharer lists the shares shared by him to a federated user.

Scenario: sharer lists the shares shared by him to a federated user

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 self-assigned this Oct 14, 2024
@prashant-gurung899 prashant-gurung899 mentioned this pull request Oct 14, 2024
Open
24 tasks
@prashant-gurung899 prashant-gurung899 changed the title [tests-only][full-ci] add test to list shares shared by sharer to federated user [tests-only][full-ci] add test to list shares shared to federated user Oct 14, 2024
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-sharedbyme branch 3 times, most recently from f7233ca to 50eb6d5 Compare October 15, 2024 04:49
@prashant-gurung899 prashant-gurung899 marked this pull request as ready for review October 15, 2024 05:42
PrajwolAmatya
PrajwolAmatya approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

saw-jan
saw-jan reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others look good

tests/acceptance/features/apiOcm/share.feature Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@saw-jan saw-jan merged commit f49f448 into master Oct 17, 2024
4 checks passed
@saw-jan saw-jan deleted the tests-ocm-sharedbyme branch October 17, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajwolAmatya PrajwolAmatya PrajwolAmatya approved these changes

@saw-jan saw-jan saw-jan approved these changes

@ishabaral ishabaral Awaiting requested review from ishabaral

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

Assignees

@prashant-gurung899 prashant-gurung899

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prashant-gurung899 @anon-pradip @saw-jan @PrajwolAmatya