Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/url-shortcuts] Open and create .url shortcut files #1344

Merged
merged 12 commits into from
May 13, 2024
Merged

[feature/url-shortcuts] Open and create .url shortcut files #1344

merged 12 commits into from
May 13, 2024

Commits on May 13, 2024

  1. - INIFile: simple parse for .ini-file format files 

    - INIFile+URLFile: simple extension for quickly parsing and composing .url files
- URLDisplayViewController: stub implementation to handle .url files
    @felix-schwarz
    felix-schwarz committed May 13, 2024
    Configuration menu
    Copy the full SHA
    356ff3f View commit details
    Browse the repository at this point in the history

  2. - URLDisplayViewController: implement code to display and allow openi… 

    …ng shortcut URL

- CreateURLShortcutAction: new action to create a URL shortcut in a folder
- design and add "text-uri-list" icon
    @felix-schwarz
    felix-schwarz committed May 13, 2024
    Configuration menu
    Copy the full SHA
    413f8b4 View commit details
    Browse the repository at this point in the history

  3. - Action: add new .directOpen location to allow actions to directly… 

    … open files from file lists, overriding viewers if needed

- OCItem+Interactions: add support for `.directOpen` actions
- INIFile+ShortcutResolution: implement support for shortcuts to other items on the same server
- ShortcutFileDisplayViewController: implement support for shortcuts to other items on the same server, including an item preview
- add new action OpenShortcutFileAction
	- hooks into the `.directOpen` location
	- uses INIFile+ShortcutResolution to open the contained link or jump to the targeted location
	- asks users before opening links
- rename files for better distinctibility:
	- URLDisplayViewController -> ShortcutFileDisplayViewController
	- CreateURLShortcutAction -> CreateShortcutFileAction
- OCItem+UniversalItemListCellContentProvider: fix warning
    @felix-schwarz
    felix-schwarz committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b8782aa View commit details
    Browse the repository at this point in the history

  4. - regrouping shortcut actions into their own folder 

    - CreateShortcutFileAction: break out creation functionality into its own view controller
- CreateShortcutFileViewController:
	- dedicated view controller for creating shortcuts
	- allows picking files and folders for shortcuts to point to and presents an embedded preview for them
	- improved error handling
- INIFile: fix formatting bug that could accidentally leak memory into the .url file
- ClientLocationPicker: add ability to allow picking files via new .allowFileSelection property
    @felix-schwarz
    felix-schwarz committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5dc90ee View commit details
    Browse the repository at this point in the history

  5. - OpenShortcutFileAction: use correct (localized) string in alert button

    @felix-schwarz
    felix-schwarz committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c719f55 View commit details
    Browse the repository at this point in the history

  6. - update SDK to fix an issue arising from Available Offline policies … 

    …targeting unavailable/detached drives and removes the respective policies

- adapt app code to SDK API changes
    @felix-schwarz
    felix-schwarz committed May 13, 2024
    Configuration menu
    Copy the full SHA
    819b789 View commit details
    Browse the repository at this point in the history

  7. - Shortcuts: 

    	- improved error reporting for when the target of a shortcut can't be accessed / found
	- simplified and generalized prompt for opening the URL a shortcut points to
    @felix-schwarz
    felix-schwarz committed May 13, 2024
    Configuration menu
    Copy the full SHA
    8ee1a2c View commit details
    Browse the repository at this point in the history

  8. - OpenShortcutFileAction, ShortcutFileDisplayViewController, INIFile+… 

    …ShortcutResolution: add MDM option to allow all shortcuts, only URL shortcuts, only item shortcuts or no shortcuts
    @felix-schwarz
    felix-schwarz committed May 13, 2024
    Configuration menu
    Copy the full SHA
    6ff12b2 View commit details
    Browse the repository at this point in the history

  9. - Fix: selecting the root folder of a space or the personal folder's … 

    …root, the name for the shortcut was not derived correctly
    @felix-schwarz
    felix-schwarz committed May 13, 2024
    Configuration menu
    Copy the full SHA
    36ff50a View commit details
    Browse the repository at this point in the history

  10. Configuration documentation updated

    @felix-schwarz
    felix-schwarz committed May 13, 2024
    Configuration menu
    Copy the full SHA
    db7aebf View commit details
    Browse the repository at this point in the history

  11. Configuration documentation updated

    @felix-schwarz
    felix-schwarz committed May 13, 2024
    Configuration menu
    Copy the full SHA
    86f267d View commit details
    Browse the repository at this point in the history

  12. - PrivacyInfo.xcprivacy: remove extraneous space 

    - Localizable.strings: re-add strings auto-removed by git during rebase
    @felix-schwarz
    felix-schwarz committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ccfdc0d View commit details
    Browse the repository at this point in the history