feat(web.hosting): move metrics to mimir #14320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cyril.biencourt <[email protected]>
github-actions
bot
added
universe-web-cloud
universe-bare-metal-cloud
translation required
dependencies
|
| Name | Status | Previous | Current |
|---|---|---|---|
chartjs-plugin-datasource-prometheus |
2.2.0 | 2.3.0 |
|
tibs245
reviewed
Nov 28, 2024
.../manager/apps/web/client/app/hosting/automated-emails/hosting-automated-emails.controller.js
Show resolved
Hide resolved
tibs245
reviewed
Nov 28, 2024
Comment on lines
+99
to
+100
| findInBorderColorMap: () => '#848CBC', | ||
| findInBackgroundColorMap: () => '#EAECF4', |
There was a problem hiding this comment.
Maybe export on a constant ?
There was a problem hiding this comment.
Used once only and specific to this chart
tibs245
reviewed
Nov 28, 2024
Comment on lines
+115
to
+123
| return fetch(url, { headers }) | ||
| .then((response) => { | ||
| if (response.ok) { | ||
| return response.json(); | ||
| } | ||
|
|
||
| return null; | ||
| }) | ||
| .then((response) => response.data); |
There was a problem hiding this comment.
No needs and avoid angularjs dependencies
rjamet-ovh
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterDescription
Move Webhosting metrics to mimir