fix(select): change label on slot change #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpellier
reviewed
Oct 5, 2023
packages/components/select/src/components/osds-select/osds-select.tsx
Outdated
Show resolved
Hide resolved
dpellier
reviewed
Oct 10, 2023
packages/components/select/src/components/osds-select/osds-select.tsx
Outdated
Show resolved
Hide resolved
aesteves60
force-pushed
the
fix/select-label
branch
2 times, most recently
from
f0750c3
to
6082c2d
Compare
aesteves60
force-pushed
the
fix/select-label
branch
from
6082c2d
to
355f6e5
Compare
dpellier
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: select-option content change but the label of a selected value don't change.
selectedLabelbecause it's up to the client to change the slotonSlotChangedon't work when just the text change