fix(modal): closed in Storybook on window location change #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpellier
requested changes
Sep 28, 2023
packages/components/modal/src/components/osds-modal/osds-modal.tsx
Outdated
Show resolved
Hide resolved
packages/storybook/stories/components/modal/modal.web-components.stories.ts
Show resolved
Hide resolved
dpellier
requested changes
Oct 4, 2023
packages/storybook/stories/components/modal/modal.web-components.stories.ts
Outdated
Show resolved
Hide resolved
manoncarbonnel
force-pushed
the
fix/modal-storybook
branch
from
a55df19
to
26e81c7
Compare
manoncarbonnel
force-pushed
the
fix/modal-storybook
branch
from
26e81c7
to
03671e5
Compare
dpellier
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 In storybook, modal component keeps opened on route change and modals can overlap each other.