Start fixing bugs discovered by Node.js's Node-API tests #14501
+26,899
−3,109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
190n
changed the title
… ben/fix-node-napi-tests
… ben/fix-node-napi-tests
This reverts commit 30eda1e.
… ben/fix-node-napi-tests
190n
commented
Nov 22, 2024
Comment on lines
1427
to
1431
| .windows => { | ||
| std.posix.abort(); | ||
| // This exit code is what Node.js uses when it calls | ||
| // abort. This is relied on by their Node-API tests. | ||
| bun.C.quick_exit(134); | ||
| }, |
There was a problem hiding this comment.
Can we change Node's test so it accepts whatever exit code std.posix.abort results in?
Comment on lines
+1778
to
+1784
| export fn Bun__crashHandler(message_ptr: [*]u8, message_len: usize) noreturn { | ||
| crashHandler(.{ .panic = message_ptr[0..message_len] }, null, @returnAddress()); | ||
| } | ||
|
|
||
| comptime { | ||
| _ = &Bun__crashHandler; | ||
| } |
There was a problem hiding this comment.
This should be unnecessary if we can get the WTF release assertions to work.
Comment on lines
39
to
40
| // TODO(@heimskr): get finalizers in workers working again | ||
| // checkOutput(requireAs(__filename, ['--expose-gc'], runOptions, 'worker')); |
There was a problem hiding this comment.
Let's see if this test still fails
| @@ -8,6 +8,7 @@ static int cleanup_hook_count = 0; | |||
| static void cleanup(void* arg) { | |||
| cleanup_hook_count++; | |||
| printf("cleanup(%d)\n", *(int*)(arg)); | |||
| fflush(stdout); | |||
There was a problem hiding this comment.
Commit this change in 190n/node
| @@ -34,6 +34,7 @@ const failingNodeApiTests = [ | |||
| "test_threadsafe_function/test.js", | |||
| "test_threadsafe_function/test_legacy_uncaught_exception.js", | |||
| "test_worker_buffer_callback/test.js", | |||
| "test_worker_buffer_callback/test-free-called.js", // TODO(@heimskr) | |||
There was a problem hiding this comment.
Let's see if we can unskip this
| @@ -98,14 +104,14 @@ beforeAll(async () => { | |||
| } | |||
| } | |||
|
|
|||
| const parallelism = Math.min(8, os.cpus().length); | |||
| const parallelism = Math.min(8, os.cpus().length, 1 /* TODO(@heimskr): remove */); | |||
test/napi/node-napi.test.ts
Outdated
Comment on lines
73
to
76
| const start = Date.now(); | ||
|
|
||
| async function buildOne(dir: string) { | ||
| console.log(`Building in ${dir.replace(/.+node-napi-tests.test./, "")}.`, (Date.now() - start) / 1000, "s elapsed"); |
| @@ -770,6 +770,8 @@ pub const EventLoop = struct { | |||
| immediate_tasks: Queue = undefined, | |||
| next_immediate_tasks: Queue = undefined, | |||
|
|
|||
| napi_finalizer_queue: JSC.napi.Finalizer.Queue = undefined, | |||
There was a problem hiding this comment.
definitely shouldn't be undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TODO before merging:
remove dependency on JSC change formerged JSC change insteadnapi_get_property_names(@heimskr)Fixes #14336
Fixes #15383
Fixes #15429
Tests in
js-native-apiHow did you verify your code works?
Running Node's tests