-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor node:module #14227
Merged
Merged
Refactor node:module #14227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ @Jarred-Sumner, your commit fc4132b has 7 failures in test/v8/v8.test.ts - 20 failing on 🪟 x64-baselinetest/v8/v8.test.ts - 20 failing on 🪟 x64test/js/web/streams/streams.test.js - 1 failing on 🍎 14 aarch64test/cli/run/run-crash-handler.test.ts - timeout on 🪟 x64test/cli/run/run-crash-handler.test.ts - timeout on 🪟 x64-baselinetest/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 aarch64test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 aarch64test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 x64test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64-baselinetest/cli/hot/watch.test.ts - 1 failing on 🪟 x64test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baselinetest/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baselinetest/cli/watch/watch.test.ts - 2 failing on 🪟 x64 |
dylan-conway
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file does not seem to be formatted correctly
dylan-conway
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor node:module to add missing properties and be a lot closer to what Node does
Main goal of this PR is to unblock optimizing _resolveFilename, which is used heavily by Next.js and shows up near the top when profiling.
Fixes #6227
Fixes #8974
How did you verify your code works?
Draft. Something is wrong currently with the static hash table causing it to never materialize the properties.